http-client-java, bug fix, array encoding support closed enum #9413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
weidongxu-microsoft
requested review from
XiaofeiCao,
anuchandy,
haolingdong-msft and
srnagar
as code owners
Member
|
could you please show the generated code diff by adding the fix? |
Contributor
Author
I cannot, because without this fix, emitter crashes, and there is no code generated. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for array encoding (comma-separated string representation) of closed enum types in the Java HTTP client generator. The change introduces a new ConvertFromJsonTypeTrait interface and updates the deserialization logic to properly handle enum values when deserializing from array-encoded strings.
Changes:
- Introduced
ConvertFromJsonTypeTraitinterface for converting JSON wire values back to client types - Implemented the new trait on
PrimitiveType,ClassType, andEnumTypeto support bidirectional conversion - Fixed array encoding deserialization logic in
StreamSerializationModelTemplateto use the new conversion trait instead of relying ondefaultValueExpression - Added unit tests for both
ConvertToJsonTypeTraitandConvertFromJsonTypeTraitconversion methods
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ConvertFromJsonTypeTrait.java | New interface defining conversion from JSON wire type to client type |
| ConvertToJsonTypeTrait.java | Updated documentation to clarify it converts to JSON wire type |
| PrimitiveType.java | Implements ConvertFromJsonTypeTrait and updates convertToJsonType to properly handle client-to-wire conversion |
| ClassType.java | Implements ConvertFromJsonTypeTrait with explicit handling for various special types like DATE_TIME, DURATION, URL |
| EnumType.java | Implements ConvertFromJsonTypeTrait to support enum deserialization from JSON values |
| StreamSerializationModelTemplate.java | Fixes array encoding deserialization to use ConvertFromJsonTypeTrait instead of defaultValueExpression, with proper error handling |
| ConvertToJsonTypeTraitTests.java | New test file verifying type conversion to JSON representation |
| ConvertFromJsonTypeTraitTests.java | New test file verifying type conversion from JSON representation |
...osoft/typespec/http/client/generator/core/model/clientmodel/ConvertToJsonTypeTraitTests.java
Show resolved
Hide resolved
...oft/typespec/http/client/generator/core/model/clientmodel/ConvertFromJsonTypeTraitTests.java
Show resolved
Hide resolved
...main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ClassType.java
Outdated
Show resolved
Hide resolved
…/src/main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ClassType.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
...main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ClassType.java
Show resolved
Hide resolved
.../java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/PrimitiveType.java
Show resolved
Hide resolved
XiaofeiCao
reviewed
Jan 20, 2026
...main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ClassType.java
Show resolved
Hide resolved
XiaofeiCao
approved these changes
Jan 21, 2026
XiaofeiCao
approved these changes
Jan 21, 2026
weidongxu-microsoft
deleted the
http-client-java_array-encoding-support-closed-enum
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
missed one `return` in PR #9413 commit d12f548 tested in Azure/autorest.java#3271 https://dev.azure.com/azure-sdk/public/_build/results?buildId=5777927&view=results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test not yet published https://github.com/microsoft/typespec/blob/main/packages/http-specs/specs/encode/array/main.tsp#L44-L62